<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29729">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29729#inline-170124">View Inline</a><span style="color: #4b4d51; font-weight: bold;">options.cpp:761</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">setOperationMaxButtonLeftClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonLeftClickCommand"</span><span class="p">,</span> <span style="color: #766510">"Maximize"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">setOperationMaxButtonMiddleClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonMiddleClickCommand"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Maximize (v</span>ertical<span class="bright"> only)</span>"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">setOperationMaxButtonMiddleClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonMiddleClickCommand"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">V</span>ertical<span class="bright">ly Maximize</span>"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">setOperationMaxButtonRightClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonRightClickCommand"</span><span class="p">,</span> <span style="color: #766510">"Maximize (horizontal only)"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Maximize" must be in lowecase.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29729#inline-170125">View Inline</a><span style="color: #4b4d51; font-weight: bold;">options.cpp:762</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">setOperationMaxButtonMiddleClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonMiddleClickCommand"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Maximize (v</span>ertical<span class="bright"> only)</span>"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">setOperationMaxButtonMiddleClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonMiddleClickCommand"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">V</span>ertical<span class="bright">ly Maximize</span>"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">setOperationMaxButtonRightClick</span><span class="p">(</span><span class="n">windowOperation</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"MaximizeButtonRightClickCommand"</span><span class="p">,</span> <span style="color: #766510">"Maximize (horizontal only)"</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The default value for right click hasn't been adjusted.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29729#inline-170126">View Inline</a><span style="color: #4b4d51; font-weight: bold;">options.cpp:985-987</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Maximize (v</span>ertical<span class="bright"> only)</span>"))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">V</span>ertical<span class="bright">ly maximize</span>"</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">return</span> <span class="n">VMaximizeOp</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Maximize (h</span>orizontal<span class="bright"> only)</span>"))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">name</span> <span style="color: #aa2211">==</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"<span class="bright">H</span>orizontal<span class="bright">ly maximize</span>"</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This will break existing user installations.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29729">https://phabricator.kde.org/D29729</a></div></div><br /><div><strong>To: </strong>ngraham, zzag, VDG, KWin, davidedmundson<br /><strong>Cc: </strong>kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>