D27861: WIP: Rework xdg-shell implementation

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in wayland_server.cpp:149
> Well, yeah. I just wanted to keep things as generic as possible. Will remove it.

Hmm, apol has a patch series that implements zwp_input_panel_surface_v1. Unfortunately, the input method spec allows clients to create input panel surfaces with already attached buffers. Given that we'll need this code path later, I suggest to keep it so we don't have to re-introduce it again.

> davidedmundson wrote in xdgshellclient.cpp:116
> We leak the m_lastAckedConfigure if someone calls ackConfigure and gets deleted before commit.
> 
> I'm guessing you didn't use unique_ptr because of the QQueue, but storing via a qsharedpointer would work nicely.

Yes, I didn't want to use QScopedPointer because it's not a movable type. On the other hand, I considered QSharedPointer to be an overkill so I decided to do memory management the hard way. Anyway, I think we could use QScopedPointer for storing the last acknowledged configure event.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27861

To: zzag, #kwin
Cc: anthonyfieroni, univerz, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200512/c6084f28/attachment.htm>