D28320: [kwineffects] Port GLPlatform to QRegularExpression

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> apol wrote in kwinglplatform.cpp:97
> It could make sense to return a QStringRef, we'd get to save a bunch of string allocations and copies.

Yes, it would be great, but could we maybe do it in another patch? QString and QStringRef have minor API differences so it's not just about replacing a few QStrings by QStringRefs. Such a change would look unrelated if you ask me.

REPOSITORY
  R108 KWin

BRANCH
  port-kwinglplatform-to-qregularexpression

REVISION DETAIL
  https://phabricator.kde.org/D28320

To: zzag, #kwin, apol
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200327/a98a95b5/attachment.html>