D28320: [kwineffects] Port GLPlatform to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kwinglplatform.cpp:97
>  // Extracts the portion of a string that matches a regular expression
> -static QString extract(const QString &string, const QString &match, int offset = 0)
> +static QString extract(const QString &text, const QString &pattern)
>  {

It could make sense to return a QStringRef, we'd get to save a bunch of string allocations and copies.

REPOSITORY
  R108 KWin

BRANCH
  port-kwinglplatform-to-qregularexpression

REVISION DETAIL
  https://phabricator.kde.org/D28320

To: zzag, #kwin, apol
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200327/6bb085f5/attachment.html>