D27955: KCM/Compositing: Use KConfig XT to store values

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Mar 19 13:24:40 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> ervin wrote in compositing.cpp:80
> That `- 4` is very obscure here

Heh, `- 4` and `+ 4` were obscure before so this patch doesn't make things better or worse. Just for context, we add and subtract 4 because long time ago `HiddenPreviews` had values with different meaning than what we have now. In order to break backwards compatibility, the new values were shifted by 4.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27955

To: meven, #kwin, ervin, bport, crossi, hchain, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200319/abad713b/attachment.html>


More information about the kwin mailing list