D27955: KCM/Compositing: Use KConfig XT to store values

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  It's a first step toward using addConfig later on,right?

INLINE COMMENTS

> compositing.cpp:80
> +    setAnimationSpeed(m_settings->animationDurationFactor());
> +    setWindowThumbnail(m_settings->hiddenPreviews() - 4);
> +    setGlScaleFilter(m_settings->gLTextureFilter());

That `- 4` is very obscure here

> compositing.cpp:81
> +    setWindowThumbnail(m_settings->hiddenPreviews() - 4);
> +    setGlScaleFilter(m_settings->gLTextureFilter());
> +    setXrScaleFilter(m_settings->xRenderSmoothScale());

Would be nice to use key + name in the kcfg to have proper capitalization for "gl"

> compositing.cpp:84
> +    setCompositingEnabled(m_settings->enabled());
> +    setGlSwapStrategy(m_settings->gLPreferBufferSwap());
>  

ditto

> compositing.cpp:102
>  
> -    const QModelIndex index = m_openGLPlatformInterfaceModel->indexForKey(kwinConfig.readEntry("GLPlatformInterface", "glx"));
> +    const QModelIndex index = m_openGLPlatformInterfaceModel->indexForKey(m_settings->gLPlatformInterface());
>      setOpenGLPlatformInterface(index.isValid() ? index.row() : 0);

ditto

> compositing.cpp:263
> +    m_settings->setGLPreferBufferSwap(glSwapStrategy());
> +    int backend;
>      bool glCore = false;

would be nice to initialize it

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27955

To: meven, #kwin, ervin, bport, crossi, hchain, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200316/77307fe0/attachment-0001.html>