D28105: Send keyboard map from a read only source

David Edmundson noreply at phabricator.kde.org
Tue Mar 17 17:25:06 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We don't want one client to modify the keymap sent to others. It will
  cause crashes or worse.
  
  This patch reopens the file after it has been set to read only, then
  unlinks the original file.
  
  BUG: 381674

TEST PLAN
  Ran test attached to the bug
  future dolphin instances start up without crashing
  those instances seem to have a working keymap

REPOSITORY
  R108 KWin

BRANCH
  davidedmundson/simplify_outputs

REVISION DETAIL
  https://phabricator.kde.org/D28105

AFFECTED FILES
  xkb.cpp

To: davidedmundson, #kwin
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/3fedc464/attachment.html>


More information about the kwin mailing list