D28101: [Toplevel] Check info being null

David Edmundson noreply at phabricator.kde.org
Tue Mar 17 15:07:15 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in toplevel.cpp:218-220
> Don't need this check because getResourceClass is only called by X11Client and Unmanaged.

Sure, that's the case currently...otherwise we'd be seeing a tonne of crash reports all over the place.

But we shouldn't have any code paths that look safe but will randomly crash.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28101

To: broulik, #kwin, davidedmundson
Cc: zzag, davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/1cb85ee1/attachment-0001.html>


More information about the kwin mailing list