D28062: Fix compiler warnings

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Mar 17 14:00:16 GMT 2020


zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> zzag wrote in showfps.cpp:126
> `wasRunning` is unused.

Please address this comment before landing.

> egl_gbm_backend.cpp:197
>          // OpenGL gives RGBA; Qt wants ARGB
> -        uint *p = (uint*)img.bits();
> +        uint *p = reinterpret_cast<uint*>(img.bits());
>          uint *end = p + w * h;

nit: add whitespace before `*`

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28062

To: apol, #kwin, zzag
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/76237053/attachment.html>


More information about the kwin mailing list