<table><tr><td style="">zzag accepted this revision.<br />zzag added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28062">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-159240">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">showfps.cpp:126</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">wasRunning</tt> is unused.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please address this comment before landing.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-159244">View Inline</a><span style="color: #4b4d51; font-weight: bold;">egl_gbm_backend.cpp:197</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// OpenGL gives RGBA; Qt wants ARGB</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">p</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">uint</span><span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">img</span><span class="p">.</span><span class="n">bits</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">p</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">reinterpret_cast</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="n">uint</span><span style="color: #aa2211">*<span class="bright">></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">img</span><span class="p">.</span><span class="n">bits</span><span class="p">(<span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">end</span> <span style="color: #aa2211">=</span> <span class="n">p</span> <span style="color: #aa2211">+</span> <span class="n">w</span> <span style="color: #aa2211">*</span> <span class="n">h</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nit: add whitespace before <tt style="background: #ebebeb; font-size: 13px;">*</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28062">https://phabricator.kde.org/D28062</a></div></div><br /><div><strong>To: </strong>apol, KWin, zzag<br /><strong>Cc: </strong>zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>