D28085: Adapt to new KScreenLocker API

Roman Gilg noreply at phabricator.kde.org
Tue Mar 17 00:48:40 GMT 2020


romangg added inline comments.

INLINE COMMENTS

> apol wrote in wayland_server.cpp:511
> Sounds like if KSldApp wasn't a singleton much of the cleanup code would be much simpler. It could maybe make sense to revisit this?

Oh yea. I guess it would also make the autotest easier to maintain since you could just reset the screen locker.

(In regards to the autotest see also: https://bugreports.qt.io/browse/QTBUG-82911)

And actually I tried to make it a member of WaylandServer (and already replaced all the `KSldApp::self()` getters in the code base with some `waylandServer()->screenLocker()` getter). But crudely enough the screen locker is already queried before the WaylandServer singleton is created by classes like PointerInputRedirection.

What sounds kind of wrong. But to tackle this there would be a larger refactoring needed for the startup order or with which class the screen locker interfaces.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28085

To: romangg, #kwin
Cc: apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200317/a3141d49/attachment-0001.html>


More information about the kwin mailing list