D27862: KCM KWinTouchScreen port to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  It's only a first step right? We'll move toward addConfig in a further step? Wondering what the plan is there.

INLINE COMMENTS

> zzag wrote in touch.cpp:74
> Could you please use an explicit type here? It's not obvious what type `setting` has.
> 
> https://community.kde.org/Policies/Library_Code_Policy#auto_Keyword

If I had my way this policy would get an update. This is "obviously" a setting object so it can be loaded. ;-)

More seriously, and more importantly (to me) this lacks a qAsConst for m_scriptSettings

> touch.cpp:86
> +    m_settings->save();
> +    for (auto setting : m_scriptSettings) {
> +        setting->save();

qAsConst missing

> touch.cpp:107
> +    m_settings->setDefaults();
> +    for (auto setting : m_scriptSettings) {
> +        setting->setDefaults();

qAsConst missing

> touch.h:99
> +    static ElectricBorderAction electricBorderActionFromString(const QString &s);
> +    static QString electricBorderActionToString(int a);
>  };

a -> action also I wonder why it's an int and not ElectricBorderAction

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27862

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200305/c8917566/attachment.html>