D27862: KCM KWinTouchScreen port to KConfigXT

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> touch.cpp:74
> +    m_settings->load();
> +    for (auto setting : m_scriptSettings) {
> +        setting->load();

Could you please use an explicit type here? It's not obvious what type `setting` has.

https://community.kde.org/Policies/Library_Code_Policy#auto_Keyword

> touch.cpp:448
> +
> +QString KWinScreenEdgesConfig::electricBorderActionToString(int a)
> +{

No short names

int a -> int action

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27862

To: crossi, #kwin, ervin, bport, meven, zzag
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200305/cd576115/attachment.html>