D26381: Port DesktopGrid QtQuickWindow to EffectQuickView

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in desktopgrid.cpp:105
> I've said before that if we are to have a policy on auto, can we try to start a thread on https://techbase.kde.org/Policies/Frameworks_Coding_Style  about auto.
> 
> Same for the colon.
> And maybe for your potential comment about defining empty methods :P

Well, it's true, usage of `auto` is not covered by any coding convention in KDE afaik, but we could use common sense to decide whether it's okay to use `auto` here

Given

  for (EffectQuickScene *view : m_desktopButtonsViews) {

and

  for (auto *view : m_desktopButtonsViews) {

Which one is more readable?

---

`view` is not an iterator and there is no repetition.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26381

To: davidedmundson, #kwin
Cc: meven, zzag, kwin, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200116/b8ce95f1/attachment-0001.html>