D26381: Port DesktopGrid QtQuickWindow to EffectQuickView

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in desktopgrid.cpp:105
> Please don't use `auto` here, it obfuscates code rather than erases redundancy. Also, there has to be whitespace before `:`.

I've said before that if we are to have a policy on auto, can we try to start a thread on https://techbase.kde.org/Policies/Frameworks_Coding_Style  about auto.

Same for the colon.
And maybe for your potential comment about defining empty methods :P

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26381

To: davidedmundson, #kwin
Cc: meven, zzag, kwin, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200116/2fa93d06/attachment.html>