D27333: Return early if close button accepts input event

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Feb 11 22:22:12 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> presentwindows.cpp:541
>      }
> +    me->setAccepted(false);
>      if (m_closeView) {

Wouldn't it be better to check `QEvent::isAccepted()` in `EffectsHandlerImpl::checkInputWindowEvent()`?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27333

To: davidedmundson, #kwin
Cc: zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200211/800d0c03/attachment.html>


More information about the kwin mailing list