D27333: Return early if close button accepts input event

David Edmundson noreply at phabricator.kde.org
Tue Feb 11 21:29:16 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise we close the effect whenever the close is pressed which is a
  behavioural change.
  
  That in turn leads to bigger bugs
  
  BUG: 415155

TEST PLAN
  Ran effect
  Clicked on the "Whitespace" of the dash
  Clicked on the close
  
  Now matches desktopgrid code

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27333

AFFECTED FILES
  effects/presentwindows/presentwindows.cpp

To: davidedmundson, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200211/f906338d/attachment.html>


More information about the kwin mailing list