D27174: actually draw drag icons in the mouse cursor during drags

[David Edmundson]

davidedmundson added a comment.


  > which doesn't seem to have a wayland protocol correspondence
  
  It does.
  
  A drag has a surface
  A surface has a buffer
  A buffer has an offset (or hotspot) to the surface
  
  Qt does set this:         
  qwaylanddnd.cpp:70

INLINE COMMENTS

> pointer_input.cpp:1261
> +    } else {
> +        QImage cursor = buffer->data().copy();
> +        m_drag.cursor.image = QImage(m_drag.cursor.hotSpot.x() + additionalIcon.width(), m_drag.cursor.hotSpot.y() + additionalIcon.height(), QImage::Format_ARGB32_Premultiplied);

I don't think this is needed given we are copying (implicitly) via the painting into another surface

we can just p.drawImage(p_.data());

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27174

To: mart, #plasma, #kwin
Cc: davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200205/fe7534bf/attachment.html>