<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27174">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>which doesn't seem to have a wayland protocol correspondence</p></blockquote>

<p>It does.</p>

<p>A drag has a surface<br />
A surface has a buffer<br />
A buffer has an offset (or hotspot) to the surface</p>

<p>Qt does set this:         <br />
qwaylanddnd.cpp:70</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27174#inline-153612">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pointer_input.cpp:1261</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QImage</span> <span class="n">cursor</span> <span style="color: #aa2211">=</span> <span class="n">buffer</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">().</span><span class="n">copy</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_drag</span><span class="p">.</span><span class="n">cursor</span><span class="p">.</span><span class="n">image</span> <span style="color: #aa2211">=</span> <span class="n">QImage</span><span class="p">(</span><span class="n">m_drag</span><span class="p">.</span><span class="n">cursor</span><span class="p">.</span><span class="n">hotSpot</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">additionalIcon</span><span class="p">.</span><span class="n">width</span><span class="p">(),</span> <span class="n">m_drag</span><span class="p">.</span><span class="n">cursor</span><span class="p">.</span><span class="n">hotSpot</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">additionalIcon</span><span class="p">.</span><span class="n">height</span><span class="p">(),</span> <span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format_ARGB32_Premultiplied</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think this is needed given we are copying (implicitly) via the painting into another surface</p>

<p style="padding: 0; margin: 8px;">we can just p.drawImage(p_.data());</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27174">https://phabricator.kde.org/D27174</a></div></div><br /><div><strong>To: </strong>mart, Plasma, KWin<br /><strong>Cc: </strong>davidedmundson, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>