D29131: [scene] Generate window quads for sub-surfaces

[Vlad Zahorodnii]

zzag marked an inline comment as done.
zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in scene.cpp:1180
> I know it's existing code, but we should be checking for a buffer here
> 
> the docs say "A sub-surface is hidden if the parent becomes hidden, "

I didn't do it because I didn't want to change how kwin references buffers. Should I change it?

> davidedmundson wrote in scene.cpp:411
> I feel like the monitor should be responsible for abstracting added/removed/mapped/unmapped into just 2 signals when we gain a valid subsurface and when a subsurface loses validity (either from being removed or unmapped)
> 
> If the subsurface changes and it has no buffer then we don't need to do anything at a tree level.

Hmm, I don't particularly see the need for a new sub-surface state given the job can be done with the existing signals and states.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29131

To: zzag, #kwin
Cc: davidedmundson, meven, apol, ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200428/9af3b7a8/attachment.html>