D29055: [Wayland] Send stacking order event through plasma window management protocol

Benjamin Port noreply at phabricator.kde.org
Wed Apr 22 07:49:39 BST 2020


bport planned changes to this revision.
bport added inline comments.

INLINE COMMENTS

> zzag wrote in abstract_client.h:875
> Toplevel has already a property named `internalId`. I suggest to avoid using `internalId`. What about adding a m_windowManagementInterface accessor?

ok with that I wanted to avoid exposing too much, I will change that

> zzag wrote in wayland_server.cpp:496-498
> How's this possible?

I guess is now impossible (I have made this guard before executing this code inside a slot connected to workspaceInitialized

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29055

To: bport, zzag, davidedmundson, meven
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200422/a83bc0d1/attachment.html>


More information about the kwin mailing list