D29055: [Wayland] Send stacking order event through plasma window management protocol

[Vlad Zahorodnii]

zzag added a comment.


  I would rather prefer `plasma_window` to have a stacking order property so the plasma window management interface stays well encapsulated and to avoid using yet another type of window ids.
  
  Feel free to push this change if others are okay with it.

INLINE COMMENTS

> abstract_client.h:875
> +     */
> +    quint32 windowInternalId() const;
> +

Toplevel has already a property named `internalId`. I suggest to avoid using `internalId`. What about adding a m_windowManagementInterface accessor?

> wayland_server.cpp:496-498
> +                if (!workspace()) {
> +                    return;
> +                }

How's this possible?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29055

To: bport, zzag, davidedmundson, meven
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200422/444dc898/attachment-0001.html>