D28152: KWinRules KCM Redesign

[Nathaniel Graham]

ngraham added a comment.


  Something changed because now with the default System Setting window size, when I click on the create new rule button, I see this: F8242233: Screenshot_20200416_135314.png <https://phabricator.kde.org/F8242233>
  
  Also when I click on Detect window properties, it always enters the text "navigator" into the window class text field, but adds the window title into the window title text box which is hidden by default. Is that expected?
  
  With respect to how to make the view less overwhelming, here's an idea: make each section header collapsible, and collapse all sections by default except for the Window Matching header, whose contents would be entirely visible by default. Then remember the expanded/collapsed state for each section globally, so a person who expands them all will always see them expanded in the future.

INLINE COMMENTS

> ngraham wrote in OptionsComboBox.qml:69
> would be nice if clicking anywhere in the row activated that row's checkbox

Hmm, this is not fixed yet for me. Probably you need to put a MouseArea inside the ItemDelegate that toggles the checkbox if clicked.

> RuleItemDelegate.qml:43
> +
> +        QQC2.CheckBox {
> +            id: itemEnabled

Same here; would be nice if clicking on the icon or text also activated the checkbox.

> RulesList.qml:105
> +            Kirigami.Action {
> +                text: i18n("Import")
> +                iconName: "document-import"

Give it ellipses ("`Import...`")

> ValueEditor.qml:139
> +                horizontalAlignment: Qt.AlignRight
> +                Layout.minimumWidth: 2 * Kirigami.Units.gridUnit
> +            }

Needs to be a bit bigger; the text still expands when set to 100%.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28152

To: iasensio, #plasma, #kwin, #vdg
Cc: ngraham, davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200416/5cab6f69/attachment-0001.html>