D28667: [platforms/x11] Fix valigrind warning copying window icon for windowed mode

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in x11windowed_output.cpp:104
> Please make windowImage const so we don't copy data twice over here.

NetIcon.data is non-const

const_cast would probably be safe as it seems setIcon also does a deep copy, but I'm sure adding that in the code would be frowned upon too

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28667

To: davidedmundson, #kwin, apol
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200416/8eab0f34/attachment.html>