D28667: [platforms/x11] Fix valigrind warning copying window icon for windowed mode

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Apr 14 15:58:42 BST 2020


zzag added inline comments.

INLINE COMMENTS

> x11windowed_output.cpp:104
> +        QImage windowImage = windowIcon.pixmap(size).toImage();
> +        icon.data = windowImage.bits();
>          icon.size.width = size.width();

Please make windowImage const so we don't copy data twice over here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D28667

To: davidedmundson, #kwin, apol
Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200414/af6fb2e7/attachment-0001.html>


More information about the kwin mailing list