D25427: [Wayland] Allow to take full resolution screenshot when scaling is used

[Méven Car]

meven added a comment.


  In D25427#648841 <https://phabricator.kde.org/D25427#648841>, @davidedmundson wrote:
  
  > I'm happy to argue a case of why we should do this and explore compromises, but doing any code changes or reviews before then is not a good use of time.
  
  
  Let's argue then.
  
  For single screen, there is nothing to argue, I believe, the patch solves the issue : do not downscale.
  
  For multi-screen, my two cents are that we need to cover both the uses cases : user scaled, and pixel precision.
  
  - pixel precision is needed for use cases such as debugging, "real" pixel screenshot, screenshot apps such as spectacle to allow them cropping anything on the screen without loss, last resort screenshot option.
  - user scaled: is needed for kde users to show off how beautiful their desktop is, an overview of , to show multi-screen apps (those are rare I'd say, games mostly), screenshot apps.
  
  If that sound reasonable I will add a `screenshotFullscreenScaled` or a boolean `scaled` argument to `screenshotFullscreen`, to the screenshotEffect.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25427

To: meven, davidedmundson, #kwin
Cc: nicolasfella, zzag, davidre, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200415/ed22ed14/attachment.html>