D25427: [Wayland] Allow to take full resolution screenshot when scaling is used

[Méven Car]

meven added a comment.


  In D25427#643030 <https://phabricator.kde.org/D25427#643030>, @davidedmundson wrote:
  
  > To make sure we're talking about the same thing, this is what I'm expecting that we'll generate that will be problematic
  >
  > http://static.davidedmundson.co.uk/blog/kwin_wayland_dpi/to_render.png
  
  
  At the moment my patch does this kind of output (that is not ideal).
  
  F8223356: Screenshot_20200407_172816.png <https://phabricator.kde.org/F8223356>
  
  The position of the image are just ones on top of each other.
  While I'd like to get them at the virtualGeometry positions them.

INLINE COMMENTS

> kwinglutils.cpp:1290
>      glBlitFramebuffer((s.x() - s_virtualScreenGeometry.x()) * s_virtualScreenScale,
> -                      (s_virtualScreenGeometry.height() - (s.y() - s_virtualScreenGeometry.y() + s.height())) * s_virtualScreenScale,
> +                      (s.y() - s_virtualScreenGeometry.y()) * s_virtualScreenScale,
>                        (s.x() - s_virtualScreenGeometry.x() + s.width()) * s_virtualScreenScale,

Those lines looked to me suspicious, I think I corrected them and didn't notice any issue with my changes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25427

To: meven, davidedmundson
Cc: zzag, davidre, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200407/9fe70570/attachment-0001.html>