<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25427">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25427#643030" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25427#643030</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>To make sure we're talking about the same thing, this is what I'm expecting that we'll generate that will be problematic</p>
<p><a href="http://static.davidedmundson.co.uk/blog/kwin_wayland_dpi/to_render.png" class="remarkup-link" target="_blank" rel="noreferrer">http://static.davidedmundson.co.uk/blog/kwin_wayland_dpi/to_render.png</a></p></div>
</blockquote>
<p>At the moment my patch does this kind of output (that is not ideal).</p>
<p><a href="https://phabricator.kde.org/F8223356" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F8223356: Screenshot_20200407_172816.png</a></p>
<p>The position of the image are just ones on top of each other.<br />
While I'd like to get them at the virtualGeometry positions them.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25427#inline-163027">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kwinglutils.cpp:1290</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">glBlitFramebuffer</span><span class="p">((</span><span class="n">s</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">s_virtualScreenGeometry</span><span class="p">.</span><span class="n">x</span><span class="p">())</span> <span style="color: #aa2211">*</span> <span class="n">s_virtualScreenScale</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">(</span><span class="n">s<span class="bright">_virtualScreenGeometry</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">height</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">s</span></span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">s_virtualScreenGeometry</span><span class="p">.</span><span class="n">y</span><span class="p">(<span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">height</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>))</span> <span style="color: #aa2211">*</span> <span class="n">s_virtualScreenScale</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">(</span><span class="n">s</span><span class="p">.</span><span class="n">y</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">s_virtualScreenGeometry</span><span class="p">.</span><span class="n">y</span><span class="p">())</span> <span style="color: #aa2211">*</span> <span class="n">s_virtualScreenScale</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">(</span><span class="n">s</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">s_virtualScreenGeometry</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">s</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">*</span> <span class="n">s_virtualScreenScale</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Those lines looked to me suspicious, I think I corrected them and didn't notice any issue with my changes.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25427">https://phabricator.kde.org/D25427</a></div></div><br /><div><strong>To: </strong>meven, davidedmundson<br /><strong>Cc: </strong>zzag, davidre, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>