D24240: [effects/presentwindows] Port present windows to EffectQuickView

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> presentwindows.cpp:238
>          effects->addRepaintFull();
> -    else if (!m_activated && m_motionManager.managingWindows() && !(m_closeWindow && m_closeView->isVisible())) {
> +    else if (!m_activated && m_motionManager.managingWindows() && !(m_closeView->isVisible())) {
>          // We have finished moving them back, stop processing

> m_closeView->isVisible()

This can potentially segfault if the user unchecked "Provide buttons to close the windows" in pw kcm.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24240

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190927/6323b32b/attachment.html>