<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24240">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24240#inline-137341">View Inline</a><span style="color: #4b4d51; font-weight: bold;">presentwindows.cpp:238</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">effects</span><span style="color: #aa2211">-></span><span class="n">addRepaintFull</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_activated</span> <span style="color: #aa2211">&&</span> <span class="n">m_motionManager</span><span class="p">.</span><span class="n">managingWindows</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="p">(</span><span class="n">m_close<span class="bright">Window</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="n"><span class="bright">m_close</span>View</span><span style="color: #aa2211">-></span><span class="n">isVisible</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_activated</span> <span style="color: #aa2211">&&</span> <span class="n">m_motionManager</span><span class="p">.</span><span class="n">managingWindows</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span class="p">(</span><span class="n">m_closeView</span><span style="color: #aa2211">-></span><span class="n">isVisible</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// We have finished moving them back, stop processing</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">m_closeView->isVisible()</p></blockquote>

<p style="padding: 0; margin: 8px;">This can potentially segfault if the user unchecked "Provide buttons to close the windows" in pw kcm.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24240">https://phabricator.kde.org/D24240</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart<br /></div>