D23618: Use nullptr everywhere

Roman Gilg noreply at phabricator.kde.org
Thu Sep 19 15:18:21 BST 2019


romangg accepted this revision.
romangg added a comment.


  Let's get it in 5.17 beta branch then as well. Tested it on X11 and Wayland and no related compile warnings.

INLINE COMMENTS

> client.cpp:1771
>      NET::Actions old_allowed_actions = NET::Actions(allowed_actions);
> -    allowed_actions = 0;
> +    allowed_actions = NET::Actions();
>      if (isMovable())

This is not a pure nullptr change, is it? Just for your information. If you think it's fine it's fine. See also https://doc.qt.io/qt-5/qflags.html#QFlags-2

REPOSITORY
  R108 KWin

BRANCH
  use-nullptr-everywhere

REVISION DETAIL
  https://phabricator.kde.org/D23618

To: zzag, #kwin, davidedmundson, romangg
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190919/9249af23/attachment-0001.html>


More information about the kwin mailing list