<table><tr><td style="">romangg accepted this revision.<br />romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23618">View Revision</a></tr></table><br /><div><div><p>Let's get it in 5.17 beta branch then as well. Tested it on X11 and Wayland and no related compile warnings.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23618#inline-136279">View Inline</a><span style="color: #4b4d51; font-weight: bold;">client.cpp:1771</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">Actions</span> <span class="n">old_allowed_actions</span> <span style="color: #aa2211">=</span> <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">Actions</span><span class="p">(</span><span class="n">allowed_actions</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">allowed_actions</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">allowed_actions</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">NET</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Actions</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">isMovable</span><span class="p">())</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not a pure nullptr change, is it? Just for your information. If you think it's fine it's fine. See also <a href="https://doc.qt.io/qt-5/qflags.html#QFlags-2" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qflags.html#QFlags-2</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>use-nullptr-everywhere</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23618">https://phabricator.kde.org/D23618</a></div></div><br /><div><strong>To: </strong>zzag, KWin, davidedmundson, romangg<br /><strong>Cc: </strong>romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>