D24885: [kcmkwin/kwindecoration] Elide "theme default border size" CheckBox
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Oct 23 12:36:49 BST 2019
broulik created this revision.
broulik added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise the layout explodes.
Unfortunately it seems Layouts don't shrink the items within even if there's not enough room at all, so I need this `fillWidth` + `maximumWidth` workaround.
TEST PLAN
Ideally, we'd wrap into a separate line or something but this requires more refactoring as a `RowLayout` can't do that on the spot, and a `Flow` doesn't give us the nice auto-sizing capabilities of a `Layout` :(
For 5.17 this is better than exploding the grid view outside visible bounds
Before
F7656362: Screenshot_20191023_133516.png <https://phabricator.kde.org/F7656362>
After
F7656368: Screenshot_20191023_133610.png <https://phabricator.kde.org/F7656368>
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D24885
AFFECTED FILES
kcmkwin/kwindecoration/package/contents/ui/main.qml
To: broulik, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191023/6c5a6b39/attachment.html>
More information about the kwin
mailing list