<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: KWin.<br />Herald added a project: KWin.<br />Herald added a subscriber: kwin.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24885">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Otherwise the layout explodes.<br />
Unfortunately it seems Layouts don't shrink the items within even if there's not enough room at all, so I need this <tt style="background: #ebebeb; font-size: 13px;">fillWidth</tt> + <tt style="background: #ebebeb; font-size: 13px;">maximumWidth</tt> workaround.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Ideally, we'd wrap into a separate line or something but this requires more refactoring as a <tt style="background: #ebebeb; font-size: 13px;">RowLayout</tt> can't do that on the spot, and a <tt style="background: #ebebeb; font-size: 13px;">Flow</tt> doesn't give us the nice auto-sizing capabilities of a <tt style="background: #ebebeb; font-size: 13px;">Layout</tt> :(<br />
For 5.17 this is better than exploding the grid view outside visible bounds<br />
Before<br />
<a href="https://phabricator.kde.org/F7656362" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7656362: Screenshot_20191023_133516.png</a><br />
After<br />
<a href="https://phabricator.kde.org/F7656368" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7656368: Screenshot_20191023_133610.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24885">https://phabricator.kde.org/D24885</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcmkwin/kwindecoration/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>broulik, KWin<br /><strong>Cc: </strong>kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>