D24544: tests for marcoTo be squash with the other commit

[Vlad Zahorodnii]

zzag added a comment.


  > No-one likes writing unit tests
  
  Heh, I do :-)

INLINE COMMENTS

> placement_test.cpp:218
> +    plasmaSurface->setPosition(QPoint(0, 0));
> +    Test::renderAndWaitForShown(panelSurface.data(), QSize(1280, 20), Qt::blue);
> +

Check whether the panel client has been created, i.e.

  XdgShellClient *panel = renderAndWaitForShown();
  QVERIFY(panel);

> placement_test.cpp:229
> +        surface->commit(Surface::CommitFlag::None);
> +        configSpy.wait();
> +

Missing QVERIFY.

> placement_test.cpp:235
> +
> +        auto c = Test::renderAndWaitForShown(surface, initiallyConfiguredSize, Qt::red);
> +

- Coding style: no short names
- Check whether `c` is `nullptr`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24544

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191010/0d3ae25e/attachment-0001.html>