<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24544">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>No-one likes writing unit tests</p></blockquote>

<p>Heh, I do :-)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24544#inline-138807">View Inline</a><span style="color: #4b4d51; font-weight: bold;">placement_test.cpp:218</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">plasmaSurface</span><span style="color: #aa2211">-></span><span class="n">setPosition</span><span class="p">(</span><span class="n">QPoint</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">renderAndWaitForShown</span><span class="p">(</span><span class="n">panelSurface</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n">QSize</span><span class="p">(</span><span style="color: #601200">1280</span><span class="p">,</span> <span style="color: #601200">20</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">blue</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Check whether the panel client has been created, i.e.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">XdgShellClient</span> <span style="color: #aa2211">*</span><span class="n">panel</span> <span style="color: #aa2211">=</span> <span class="n">renderAndWaitForShown</span><span class="p">();</span>
<span class="n">QVERIFY</span><span class="p">(</span><span class="n">panel</span><span class="p">);</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24544#inline-138805">View Inline</a><span style="color: #4b4d51; font-weight: bold;">placement_test.cpp:229</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">surface</span><span style="color: #aa2211">-></span><span class="n">commit</span><span class="p">(</span><span class="n">Surface</span><span style="color: #aa2211">::</span><span class="n">CommitFlag</span><span style="color: #aa2211">::</span><span class="n">None</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">configSpy</span><span class="p">.</span><span class="n">wait</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing QVERIFY.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24544#inline-138806">View Inline</a><span style="color: #4b4d51; font-weight: bold;">placement_test.cpp:235</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">auto</span> <span class="n">c</span> <span style="color: #aa2211">=</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">renderAndWaitForShown</span><span class="p">(</span><span class="n">surface</span><span class="p">,</span> <span class="n">initiallyConfiguredSize</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">red</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ul class="remarkup-list">
<li class="remarkup-list-item">Coding style: no short names</li>
<li class="remarkup-list-item">Check whether <tt style="background: #ebebeb; font-size: 13px;">c</tt> is <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt></li>
</ul></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24544">https://phabricator.kde.org/D24544</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>