D25611: [scene] Fix decoration texture bleeding

[Fredrik Höglund]

fredrik added a comment.


  In D25611#569457 <https://phabricator.kde.org/D25611#569457>, @zzag wrote:
  
  > In D25611#569453 <https://phabricator.kde.org/D25611#569453>, @fredrik wrote:
  >
  > > The decoration parts should already be padded. The commit message in the commit that introduced the atlas (6ad4c775d7840e64a07e27d6719a3ea7c3ee5eb8 <https://phabricator.kde.org/R108:6ad4c775d7840e64a07e27d6719a3ea7c3ee5eb8>) even says so:
  > >  "The images are separated by a row of transparent texels to minimize artifacts from oversampling."
  >
  >
  > Yes, it does and that's the problem since the transparent texels contribute to the final output value. Am I missing something?
  
  
  Actually I misunderstood what the patch does. I thought it added transparent padding.

INLINE COMMENTS

> scene_opengl.cpp:2616
> +            worldTransform.translate(-dirtyRect.left() - dirtyRect.width(), -dirtyRect.top());
> +            painter.setWorldTransform(worldTransform);
>          }

How does this perform compared to the rotate() function?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25611

To: zzag, #kwin
Cc: fredrik, kwin, fvogt, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191130/be8999fa/attachment-0001.html>