D25611: [scene] Fix decoration texture bleeding

Fredrik Höglund noreply at phabricator.kde.org
Fri Nov 29 17:21:18 GMT 2019


fredrik added a comment.


  The decoration parts should already be padded. The commit message in the commit that introduced the atlas (6ad4c775d7840e64a07e27d6719a3ea7c3ee5eb8 <https://phabricator.kde.org/R108:6ad4c775d7840e64a07e27d6719a3ea7c3ee5eb8>) even says so:
  "The images are separated by a row of transparent texels to minimize artifacts from oversampling."

INLINE COMMENTS

> scene.cpp:888
> -        QPoint(-rects[3].x(), -rects[3].y() + rects[1].height() + 1)                                         // Bottom
> +        QPoint(-rects[0].x(), -rects[0].y()) + leftSpritePosition,
> +        QPoint(-rects[1].x(), -rects[1].y()) + topSpritePosition,
> +        QPoint(-rects[2].x(), -rects[2].y()) + rightSpritePosition,
> +        QPoint(-rects[3].x(), -rects[3].y()) + bottomSpritePosition,
>      };
>  

That's the reason for the +1, +2 and +3 in the vertical positions here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25611

To: zzag, #kwin
Cc: fredrik, kwin, fvogt, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191129/92946c67/attachment.html>


More information about the kwin mailing list