D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Nov 12 19:23:47 GMT 2019


zzag added inline comments.

INLINE COMMENTS

> kwineffectquickview.cpp:206
> +    case QEvent::MouseMove:
> +        Q_FALLTHROUGH();
> +    case QEvent::MouseButtonPress:

Why did you put `Q_FALLTHOURGH` here? No compiler will complain about implicit fallthough in this case.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25207

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191112/7ae98329/attachment.html>


More information about the kwin mailing list