D25207: [libkwineffects] Construct correct mouse event when forwarding to QtQuickView

David Edmundson noreply at phabricator.kde.org
Fri Nov 8 10:46:06 GMT 2019


davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Original code (copied from Aurorae) created a QMouseEvent for
  QHoverEvents. Whilst it apparently worked, it's technically wrong.
  
  It's safer to have an explicit type check given we come from a downcast
  QEvent* and then build the correct event.

TEST PLAN
  Hovered some icons

REPOSITORY
  R108 KWin

BRANCH
  aurorae2

REVISION DETAIL
  https://phabricator.kde.org/D25207

AFFECTED FILES
  libkwineffects/kwineffectquickview.cpp

To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191108/8785089f/attachment-0001.html>


More information about the kwin mailing list