D25190: Translates the Search placeholder in kcm_kwin_effects
Méven Car
noreply at phabricator.kde.org
Thu Nov 7 14:03:02 GMT 2019
meven abandoned this revision.
meven added a comment.
In D25190#559587 <https://phabricator.kde.org/D25190#559587>, @davidedmundson wrote:
> > I saw from other code in plasma this was common to do this replacement.
>
> Where? There are lots of TextFields with the placeholder set.
>
> The SearchFields I found (notifications KCM, systemsettings, discover) didn't.
You are right I naively assumed some of the grep'ed instance of placeholderText concerned SeachField but it didn't.
> Which either means they exhibit the same bug, or they do something we're not doing.
They don't exhibit the bug, so the bug is most likely in kwineffects kcm.
Will look into it.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D25190
To: meven, #kwin, davidedmundson
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191107/37e35a21/attachment.html>
More information about the kwin
mailing list