D22153: blur: Disable sRGB when the framebuffer is linear

Fredrik Höglund noreply at phabricator.kde.org
Sat Jun 29 17:30:16 BST 2019


fredrik added inline comments.

INLINE COMMENTS

> zzag wrote in blur.cpp:133
> Do we need to check whether the default framebuffer object is bound?

Yes, that's probably a good idea.

> zzag wrote in blur.cpp:656
> Do we have to worry about the looking glass effect and all other effects that render the scene to a texture?

Yes, those effects will need to use an sRGB texture as well.

That being said, it looks to me like the blur effect is just broken in general when it's not rendering to the default framebuffer.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22153

To: fredrik, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190629/63f87014/attachment-0001.html>


More information about the kwin mailing list