D22195: Split Compositor class in Wayland and X11 child classes

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> romangg wrote in dbusinterface.cpp:313
> It does not make sense to put a whitespace in this case, since there is no identifier to the right of the asterisks. Sticking to rules is fine, as long as it makes sense.

Why not add matching virtual function in base, doing nothing in Wayland, every time i see exclusive check on polymorphic type is just weak design.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22195

To: romangg, #kwin
Cc: anthonyfieroni, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190710/62ce1f52/attachment-0001.html>