D22195: Split Compositor class in Wayland and X11 child classes

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in composite.h:49
> On function return values I prefer to put the asterisks without space next to the return type since it specifies the return type and not the function. If there are no counter arguments to that and you want to make a rule out of it we can discuss that at KWin sprint.

As a "WebKit coding style"-head, I agree that putting a whitespace before a pointer doesn't make sense because it's part of the type, but we follow Kdelibs/Frameworks coding style, which dictates that a whitespace has to be put before pointers or references. It doesn't matter whether it's a function or a template argument, you have to put a whitespace. Similar story with clang-format. If we run it, the asterisk will be aligned to right.

Please notice that I didn't "invent" or "make out" this rule.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22195

To: romangg, #kwin
Cc: anthonyfieroni, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190710/3c20fd3d/attachment.html>