D22277: Save Compositor state in single variable

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in composite.cpp:174
> True. But then the `m_finishing` variable was pretty useless. Because of that I assumed there was some funky callback stuff going on in the calls being done to the clients in between.

No, we still need m_finished to delay deletion of support properties, don't we?

> romangg wrote in composite.cpp:435
> Can you give a code example how you think it should look?

Something like this

  switch (m_state) {
  case State::On:
      // Comment.
      break;
  case State::Off:
      if (m_selectionOwner) {
          qCDebug(KWIN_CORE) << "Releasing compositor selection";
          m_selectionOwner->setOwning(false);
          m_selectionOwner->release();
      }
      break;
  case State::Starting:
  case State::Sopping:
      // Comment.
      m_releaseSelectionTimer.start();
      break;
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22277

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/a56cc83e/attachment-0001.html>