<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22277">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22277#inline-125559">View Inline</a><span style="color: #4b4d51; font-weight: bold;">romangg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">composite.cpp:174</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">True. But then the <tt style="background: #ebebeb; font-size: 13px;">m_finishing</tt> variable was pretty useless. Because of that I assumed there was some funky callback stuff going on in the calls being done to the clients in between.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No, we still need m_finished to delay deletion of support properties, don't we?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22277#inline-125560">View Inline</a><span style="color: #4b4d51; font-weight: bold;">romangg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">composite.cpp:435</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can you give a code example how you think it should look?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Something like this</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">m_state</span><span class="p">)</span> <span class="p">{</span>
<span style="color: #aa4000">case</span> <span class="n">State</span><span style="color: #aa2211">::</span><span style="color: #a0a000">On</span><span class="p">:</span>
    <span style="color: #74777d">// Comment.</span>
    <span style="color: #aa4000">break</span><span class="p">;</span>
<span style="color: #aa4000">case</span> <span class="n">State</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Off</span><span class="p">:</span>
    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_selectionOwner</span><span class="p">)</span> <span class="p">{</span>
        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KWIN_CORE</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Releasing compositor selection"</span><span class="p">;</span>
        <span class="n">m_selectionOwner</span><span style="color: #aa2211">-></span><span class="n">setOwning</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
        <span class="n">m_selectionOwner</span><span style="color: #aa2211">-></span><span class="n">release</span><span class="p">();</span>
    <span class="p">}</span>
    <span style="color: #aa4000">break</span><span class="p">;</span>
<span style="color: #aa4000">case</span> <span class="n">State</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Starting</span><span class="p">:</span>
<span style="color: #aa4000">case</span> <span class="n">State</span><span style="color: #aa2211">::</span><span style="color: #a0a000">Sopping</span><span class="p">:</span>
    <span style="color: #74777d">// Comment.</span>
    <span class="n">m_releaseSelectionTimer</span><span class="p">.</span><span class="n">start</span><span class="p">();</span>
    <span style="color: #aa4000">break</span><span class="p">;</span>
<span class="p">}</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22277">https://phabricator.kde.org/D22277</a></div></div><br /><div><strong>To: </strong>romangg, KWin<br /><strong>Cc: </strong>zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>