D22218: Use new slot syntax in Compositor class

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in dbusinterface.h:172
> Listen, put yourself in my shoes. I see a code base with some certain coding style, and your patch follows slightly different style. Do you even realize that such small disagreements contribute to coding style masquerade?
> 
> If you don't like the current doxygen style, then submit a patch to change it to a more main stream style. Running git grep + sed with `s/ \*\*\// \*\//` should be enough. I'll accept that patch, and I think any fellas from #plasma <https://phabricator.kde.org/tag/plasma/> do the same.
> 
> Also, I find it a bit frustrating that a lot of time goes into disputing coding style. If you don't like something, stick with it for a moment, but don't invent "new style." Address the issue in another patch.
> 
> > and I'm an active core contributor to KWin longer than you.
> 
> OK.

Yea, let's talk about this at the sprint. Just so we understand each other correctly: I don't have anything against you personally and I value your expertise and hard work on KWin.

Different people just have different styles of solving problems and if that's not organized correctly this might clash. We need to organize our project such that it suits the project, us and other part-time contributors and the KWin sprint will give us opportunity to do that.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22218

To: romangg, #kwin, zzag
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/fe228a33/attachment.html>