D22218: Use new slot syntax in Compositor class

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in dbusinterface.h:172
> And this reformatting was done without checking back on my opinion on that first although quite a lot of that code was written by me and I'm an active core contributor to KWin longer than you.
> 
> Similarly just a few days ago you reformatted my complete XWayland drag-and-drop code to your personal code rules without review or even saying anything beforehand. I hope there won't be again an excuse for you to not come to a meetup so we can discuss your behavior in regards to code styling and review etiquette later this month at the KWin sprint.

Listen, put yourself in my shoes. I see a code base with some certain coding style, and your patch follows slightly different style. Do you even realize that such small disagreements contribute to coding style masquerade?

If you don't like the current doxygen style, then submit a patch to change it to a more main stream style. Running git grep + sed with `s/ \*\*\// \*\//` should be enough. I'll accept that patch, and I think any fellas from #plasma <https://phabricator.kde.org/tag/plasma/> do the same.

Also, I find it a bit frustrating that a lot of time goes into disputing coding style. If you don't like something, stick with it for a moment, but don't invent "new style." Address the issue in another patch.

> and I'm an active core contributor to KWin longer than you.

OK.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22218

To: romangg, #kwin, zzag
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/cf03c037/attachment-0001.html>