D22218: Use new slot syntax in Compositor class

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> romangg wrote in dbusinterface.h:172
> Wrong by what arbitrary rule? Two stars is wrong when looking at upstream recommendation and other projects. I told you this already half a year ago after you went through reformatting all the code base. Still you insist on that being the "right" way to do it. We should use one star at the end of Doxygen comments consistently for new comments.

And this reformatting was done without checking back on my opinion on that first although quite a lot of that code was written by me and I'm an active core contributor to KWin longer than you.

Similarly just a few days ago you reformatted my complete XWayland drag-and-drop code to your personal code rules without review or even saying anything beforehand. I hope there won't be again an excuse for you to not come to a meetup so we can discuss your behavior in regards to code styling and review etiquette later this month at the KWin sprint.

REPOSITORY
  R108 KWin

BRANCH
  compositorSlotSyntax

REVISION DETAIL
  https://phabricator.kde.org/D22218

To: romangg, #kwin, zzag
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/c25e1bd6/attachment.html>