D22218: Use new slot syntax in Compositor class
Roman Gilg
noreply at phabricator.kde.org
Thu Jul 4 13:09:22 BST 2019
romangg added inline comments.
INLINE COMMENTS
> zzag wrote in dbusinterface.h:172
> Wrong terminator (not cyborg). Use `**/` instead.
Wrong by what arbitrary rule? Two stars is wrong when looking at upstream recommendation and other projects. I told you this already half a year ago after you went through reformatting all the code base. Still you insist on that being the "right" way to do it. We should use one star at the end of Doxygen comments consistently for new comments.
REPOSITORY
R108 KWin
BRANCH
compositorSlotSyntax
REVISION DETAIL
https://phabricator.kde.org/D22218
To: romangg, #kwin, zzag
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/f2dc43f4/attachment.html>
More information about the kwin
mailing list